Diagnostics: Removes Unnecessary APIs From Public Contract#5919
Merged
Meghana-Palaparthi merged 4 commits intoJun 2, 2026
Merged
Conversation
📝 Changelog reminder (non-blocking)This PR touches shipped source but does not appear to update the Touched (and missing entry for):
How to decideUse the rubric in
This check is non-blocking — merge is not gated on it. The |
jeet1995
previously approved these changes
Jun 2, 2026
ananth7592
previously approved these changes
Jun 2, 2026
Meghana-Palaparthi
dismissed stale reviews from ananth7592 and jeet1995
via
3530460
Meghana-Palaparthi
previously approved these changes
Jun 2, 2026
kundadebdatta
requested review from
FabianMeiswinkel,
Pilchie,
adityasa,
khdang,
kirankumarkolli,
kushagraThapar,
neildsh,
sboshra and
xinlian12
as code owners
kushagraThapar
previously approved these changes
Jun 2, 2026
Member
kushagraThapar
left a comment
kushagraThapar
left a comment
There was a problem hiding this comment.
LGTM, thanks @kundadebdatta
jeet1995
approved these changes
Jun 2, 2026
ananth7592
approved these changes
Jun 2, 2026
kushagraThapar
approved these changes
Jun 2, 2026
Meghana-Palaparthi
deleted the
users/kundadebdatta/fix_requested_regions_contract
branch
Meghana-Palaparthi
added a commit
that referenced
this pull request
Jun 2, 2026
Removes operator == and operator != from RequestedRegion struct (removed by PR #5919: Diagnostics: Removes Unnecessary APIs From Public Contract) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This PR removes unnecessary APIs from diagnostics public contract
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber
Changelog
### Unreleasedinchangelog.mdfor the user-facing impact of this change.
documentation-only, test-only, CI / build-only, or a pure internal refactor
with no observable customer impact.
If the second box is checked, briefly justify here: